a7ecd76e0a
End-to-end coverage for the workspace boundary:
- GET /api/threads/{tid} from workspace B → 404
- DELETE /api/threads/{tid} from workspace B → 404
- PATCH /api/threads/{tid} from workspace B → 404
- Positive control: same workspace → 200
Wires `MemoryThreadMetaStore` (real impl, not a mock) behind a
stub-authed FastAPI app. The check_access call inside
`@require_permission` returns False on cross-workspace and the
decorator converts to 404 — proving the boundary holds at the HTTP
boundary, not just the unit level. Run stream/wait are skipped here
(they spin a background worker); their guard goes through the same
decorator path so unit coverage in `test_require_permission_workspace`
is sufficient.
`_StubAuthMiddleware` gains `override_user_contextvar=True` so
cross-user / cross-workspace tests can drive both contextvars from the
stub. Default stays off — the autouse user fixture continues to own
the contextvar for legacy tests whose routes resolve filesystem paths
via `get_effective_user_id()`.
86 router / boundary tests stay green.
176 lines
6.8 KiB
Python
176 lines
6.8 KiB
Python
"""Helpers for router-level tests that need a stubbed auth context.
|
|
|
|
The production gateway runs ``AuthMiddleware`` (validates the JWT cookie)
|
|
ahead of every router, plus ``@require_permission(owner_check=True)``
|
|
decorators that read ``request.state.auth`` and call
|
|
``thread_store.check_access``. Router-level unit tests construct
|
|
**bare** FastAPI apps that include only one router — they have neither
|
|
the auth middleware nor a real thread_store, so the decorators raise
|
|
401 (TestClient path) or ValueError (direct-call path).
|
|
|
|
This module provides two surfaces:
|
|
|
|
1. :func:`make_authed_test_app` — wraps ``FastAPI()`` with a tiny
|
|
``BaseHTTPMiddleware`` that stamps a fake user / AuthContext on every
|
|
request, plus a permissive ``thread_store`` mock on
|
|
``app.state``. Use from TestClient-based router tests.
|
|
|
|
2. :func:`call_unwrapped` — invokes the underlying function bypassing
|
|
the ``@require_permission`` decorator chain by walking ``__wrapped__``.
|
|
Use from direct-call tests that previously imported the route
|
|
function and called it positionally.
|
|
|
|
Both helpers are deliberately permissive: they never deny a request.
|
|
Tests that want to verify the *auth boundary itself* (e.g.
|
|
``test_auth_middleware``, ``test_auth_type_system``) build their own
|
|
apps with the real middleware — those should not use this module.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from collections.abc import Callable
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
from uuid import uuid4
|
|
|
|
from fastapi import FastAPI, Request, Response
|
|
from starlette.middleware.base import BaseHTTPMiddleware
|
|
from starlette.types import ASGIApp
|
|
|
|
from app.gateway.auth.models import ActiveWorkspace, User
|
|
from app.gateway.authz import AuthContext, Permissions
|
|
from deerflow.runtime.user_context import (
|
|
reset_current_user,
|
|
set_current_user,
|
|
)
|
|
from deerflow.runtime.workspace_context import (
|
|
reset_current_workspace,
|
|
set_current_workspace,
|
|
)
|
|
|
|
# Default permission set granted to the stub user. Mirrors `_ALL_PERMISSIONS`
|
|
# in authz.py — kept inline so the tests don't import a private symbol.
|
|
_STUB_PERMISSIONS: list[str] = [
|
|
Permissions.THREADS_READ,
|
|
Permissions.THREADS_WRITE,
|
|
Permissions.THREADS_DELETE,
|
|
Permissions.RUNS_CREATE,
|
|
Permissions.RUNS_READ,
|
|
Permissions.RUNS_CANCEL,
|
|
]
|
|
|
|
|
|
def _make_stub_user() -> User:
|
|
"""A deterministic test user — same shape as production, fresh UUID."""
|
|
return User(
|
|
email="router-test@example.com",
|
|
password_hash="x",
|
|
system_role="user",
|
|
id=uuid4(),
|
|
)
|
|
|
|
|
|
class _StubAuthMiddleware(BaseHTTPMiddleware):
|
|
"""Stamp a fake user / AuthContext onto every request.
|
|
|
|
Mirrors what production ``AuthMiddleware`` does after the JWT decode
|
|
+ DB lookup short-circuit, so ``@require_permission`` finds an
|
|
authenticated context and skips its own re-authentication path.
|
|
|
|
Optionally stamps the workspace contextvar too — needed by the PR6
|
|
decorator path that calls ``get_effective_workspace_id()`` before
|
|
delegating to ``check_access``.
|
|
"""
|
|
|
|
def __init__(
|
|
self,
|
|
app: ASGIApp,
|
|
user_factory: Callable[[], User],
|
|
workspace_factory: Callable[[], ActiveWorkspace | None] | None = None,
|
|
override_user_contextvar: bool = False,
|
|
) -> None:
|
|
super().__init__(app)
|
|
self._user_factory = user_factory
|
|
self._workspace_factory = workspace_factory
|
|
# Tests that only need ``request.state.auth`` (the @require_permission
|
|
# path) keep the autouse user contextvar — flipping it to a per-call
|
|
# UUID would break legacy tests whose routes resolve paths via
|
|
# ``get_effective_user_id()``. Cross-user / cross-workspace tests opt
|
|
# in by setting this flag so the contextvar matches the request user.
|
|
self._override_user_contextvar = override_user_contextvar
|
|
|
|
async def dispatch(self, request: Request, call_next: Callable) -> Response:
|
|
user = self._user_factory()
|
|
request.state.user = user
|
|
request.state.auth = AuthContext(user=user, permissions=list(_STUB_PERMISSIONS))
|
|
|
|
user_token = set_current_user(user) if self._override_user_contextvar else None
|
|
ws_token = None
|
|
if self._workspace_factory is not None:
|
|
workspace = self._workspace_factory()
|
|
if workspace is not None:
|
|
request.state.workspace = workspace
|
|
ws_token = set_current_workspace(workspace)
|
|
try:
|
|
return await call_next(request)
|
|
finally:
|
|
if ws_token is not None:
|
|
reset_current_workspace(ws_token)
|
|
if user_token is not None:
|
|
reset_current_user(user_token)
|
|
|
|
|
|
def make_authed_test_app(
|
|
*,
|
|
user_factory: Callable[[], User] | None = None,
|
|
workspace_factory: Callable[[], ActiveWorkspace | None] | None = None,
|
|
override_user_contextvar: bool = False,
|
|
owner_check_passes: bool = True,
|
|
) -> FastAPI:
|
|
"""Build a FastAPI test app with stub auth + permissive thread_store.
|
|
|
|
Args:
|
|
user_factory: Override the default test user. Must return a fully
|
|
populated :class:`User`. Useful for cross-user isolation tests
|
|
that need a stable id across requests.
|
|
owner_check_passes: When True (default), ``thread_store.check_access``
|
|
returns True for every call so ``@require_permission(owner_check=True)``
|
|
never blocks the route under test. Pass False to verify that
|
|
permission failures surface correctly.
|
|
|
|
Returns:
|
|
A ``FastAPI`` app with the stub middleware installed and
|
|
``app.state.thread_store`` set to a permissive mock. The
|
|
caller is still responsible for ``app.include_router(...)``.
|
|
"""
|
|
factory = user_factory or _make_stub_user
|
|
app = FastAPI()
|
|
app.add_middleware(
|
|
_StubAuthMiddleware,
|
|
user_factory=factory,
|
|
workspace_factory=workspace_factory,
|
|
override_user_contextvar=override_user_contextvar,
|
|
)
|
|
|
|
repo = MagicMock()
|
|
repo.check_access = AsyncMock(return_value=owner_check_passes)
|
|
app.state.thread_store = repo
|
|
|
|
return app
|
|
|
|
|
|
def call_unwrapped[*P, R](decorated: Callable[P, R], /, *args: P.args, **kwargs: P.kwargs) -> R:
|
|
"""Invoke the underlying function of a ``@require_permission``-decorated route.
|
|
|
|
``functools.wraps`` sets ``__wrapped__`` on each layer; we walk all
|
|
the way down to the original handler, bypassing every authz +
|
|
require_auth wrapper. Use from tests that need to call route
|
|
functions directly (without TestClient) and don't want to construct
|
|
a fake ``Request`` just to satisfy the decorator. The ``ParamSpec``
|
|
propagates the wrapped route's signature so call sites still get
|
|
parameter checking despite the unwrapping.
|
|
"""
|
|
fn: Callable = decorated
|
|
while hasattr(fn, "__wrapped__"):
|
|
fn = fn.__wrapped__ # type: ignore[attr-defined]
|
|
return fn(*args, **kwargs)
|