feat(auth): lifespan _ensure_admin_user backfills missing workspace

Pre-PR4 admins have users.default_workspace_id NULL. Without this
backfill they would log in successfully but immediately bounce off the
workspace gate (T4.7) because their token cannot encode a wid. The
lifespan hook now resolves the admin user and calls
ensure_default_workspace (idempotent — no-op if the user already has
a workspace), so the post-upgrade boot makes the admin usable.

Renamed routers.auth._ensure_default_workspace → ensure_default_workspace
to make it importable across modules.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

backend/app/gateway/app.py

@@ -108,6 +108,23 @@ async def _ensure_admin_user(app: FastAPI) -> None:
 
     admin_id = str(row.id)
 
+    # Stage 0 PR4 backfill: pre-PR4 admins have no default_workspace_id.
+    # Create their personal workspace + owner membership on next boot so
+    # they can log in and pass the workspace gate without hand-rolling
+    # SQL. Idempotent — ensure_default_workspace short-circuits when the
+    # column is already set.
+    try:
+        admin_user = await provider.get_user(admin_id)
+        if admin_user is not None and not admin_user.default_workspace_id:
+            from app.gateway.routers.auth import ensure_default_workspace
+
+            ws_id = await ensure_default_workspace(admin_user)
+            logger.info("Backfilled default workspace %s for admin %s", ws_id, admin_id)
+    except Exception:
+        # Don't fail startup if backfill stumbles — the user can still
+        # log in (login_local calls the same helper on its hot path).
+        logger.exception("Admin workspace backfill failed (non-fatal)")
+
     # LangGraph store orphan migration — non-fatal.
     # This covers the "no-auth → with-auth" upgrade path for users
     # whose existing LangGraph thread metadata has no user_id set.

backend/app/gateway/routers/auth.py

@@ -23,7 +23,7 @@ from app.gateway.deps import get_current_user_from_request, get_local_provider
 logger = logging.getLogger(__name__)
 
 
-async def _ensure_default_workspace(user) -> str:
+async def ensure_default_workspace(user) -> str:
     """Create the user's personal workspace + owner membership, set default_workspace_id.
 
     Returns the new workspace id. Idempotent for users who already
@@ -343,7 +343,7 @@ async def login_local(
     _record_login_success(client_ip)
     # Ensure the user has a workspace (covers pre-PR4 users still in DB
     # whose default_workspace_id was never backfilled by the lifespan hook).
-    workspace_id = await _ensure_default_workspace(user)
+    workspace_id = await ensure_default_workspace(user)
     token = create_access_token(
         str(user.id),
         token_version=user.token_version,
@@ -373,7 +373,7 @@ async def register(request: Request, response: Response, body: RegisterRequest):
             detail=AuthErrorResponse(code=AuthErrorCode.EMAIL_ALREADY_EXISTS, message="Email already registered").model_dump(),
         )
 
-    workspace_id = await _ensure_default_workspace(user)
+    workspace_id = await ensure_default_workspace(user)
 
     token = create_access_token(
         str(user.id),
@@ -434,9 +434,9 @@ async def change_password(request: Request, response: Response, body: ChangePass
 
     # Re-issue cookie with new token_version. wid + role must be carried
     # forward so the re-signed JWT still passes the AuthMiddleware
-    # workspace gate; _ensure_default_workspace fills in for the (rare)
+    # workspace gate; ensure_default_workspace fills in for the (rare)
     # case where the user predates PR4 and has not been backfilled.
-    workspace_id = await _ensure_default_workspace(user)
+    workspace_id = await ensure_default_workspace(user)
     token = create_access_token(
         str(user.id),
         token_version=user.token_version,
@@ -555,7 +555,7 @@ async def initialize_admin(request: Request, response: Response, body: Initializ
             detail=AuthErrorResponse(code=AuthErrorCode.SYSTEM_ALREADY_INITIALIZED, message="System already initialized").model_dump(),
         )
 
-    workspace_id = await _ensure_default_workspace(user)
+    workspace_id = await ensure_default_workspace(user)
 
     token = create_access_token(
         str(user.id),